Skip to content

Finish deprecation cycle for trust_repo param in torch.hub#174101

Closed
albanD wants to merge 1 commit into
pytorch:mainfrom
albanD:hub_check_default
Closed

Finish deprecation cycle for trust_repo param in torch.hub#174101
albanD wants to merge 1 commit into
pytorch:mainfrom
albanD:hub_check_default

Conversation

@albanD

@albanD albanD commented Feb 2, 2026 •
edited by pytorch-bot Bot
Loading

Copy link
Copy Markdown
Collaborator

This was slated for removal in 2.0 but we never did it.
This ensures the default is now properly secure and the user has to validate repos before loading them.

cc @ezyang @gchanan

@albanD albanD requested a review from malfet February 2, 2026 18:43
@albanD albanD added the module: bc-breaking Related to a BC-breaking change label Feb 2, 2026
@pytorch-bot

pytorch-bot Bot commented Feb 2, 2026 •
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/174101

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 Cancelled Jobs, 28 Pending

As of commit 41a4faa with merge base db9959e (image):

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot Bot added the topic: bc breaking topic category label Feb 2, 2026
@pytorch-bot

pytorch-bot Bot commented Feb 2, 2026

Copy link
Copy Markdown

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@albanD albanD requested a review from ailzhang February 2, 2026 18:56
@albanD albanD added the release notes: python_frontend python frontend release notes category label Feb 2, 2026
ailzhang
ailzhang approved these changes Feb 2, 2026
View reviewed changes

@ailzhang ailzhang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@albanD

albanD commented Feb 2, 2026

Copy link
Copy Markdown
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot Bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 2, 2026
@malfet

malfet commented Feb 2, 2026

Copy link
Copy Markdown
Collaborator

@pytorchbot merge -f "Can we get any runners from GH today?"

@pytorchmergebot

pytorchmergebot commented Feb 2, 2026

Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

radeksm pushed a commit to radeksm/pytorch that referenced this pull request Feb 20, 2026
@albanD @radeksm
Finish deprecation cycle for trust_repo param in torch.hub (pytorch#1…
d4b8117 
…74101)

This was slated for removal in 2.0 but we never did it.
This ensures the default is now properly secure and the user has to validate repos before loading them.

Pull Request resolved: pytorch#174101
Approved by: https://github.com/ailzhang, https://github.com/malfet
libohao1201 pushed a commit to libohao1201/pytorch that referenced this pull request Mar 2, 2026
@albanD @libohao1201
Finish deprecation cycle for trust_repo param in torch.hub (pytorch#1…
cc0aa6b 
…74101)

This was slated for removal in 2.0 but we never did it.
This ensures the default is now properly secure and the user has to validate repos before loading them.

Pull Request resolved: pytorch#174101
Approved by: https://github.com/ailzhang, https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes
@ailzhang ailzhang ailzhang approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: bc-breaking Related to a BC-breaking change release notes: python_frontend python frontend release notes category topic: bc breaking topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@albanD @malfet @pytorchmergebot @ailzhang