Skip to content

Make it possible for faulthandler to terminate the pytest process on timeout #13679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RonnyPfannschmidt merged 19 commits into from
Oct 6, 2025
Merged

Make it possible for faulthandler to terminate the pytest process on timeout #13679

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
a41b231
Make it possible for faulthandler to terminate the pytest process on …
ogrisel Aug 27, 2025
91d600c
Add myself to AUTHORS and add changelog entry.
ogrisel Aug 27, 2025
d3274b1
Update the documentation
ogrisel Aug 27, 2025
be4f0ba
Skip flakky CI tests
ogrisel Aug 27, 2025
5066d98
Revert "Skip flakky CI tests"
ogrisel Aug 27, 2025
000876e
Pass the CI env in tox.ini and use it to conditionally skip tests on CI
ogrisel Aug 27, 2025
dfc2207
Revert "Pass the CI env in tox.ini and use it to conditionally skip t…
ogrisel Aug 27, 2025
c7abf41
Revert "Revert "Skip flakky CI tests""
ogrisel Aug 27, 2025
713166e
Apply suggestions from code review
ogrisel Aug 28, 2025
da1adf3
Better way to tell mypy that faulthandler_exit_on_timeout is always a…
ogrisel Aug 28, 2025
65ef53f
Merge branch 'main' into faulthandler-exit-on-timeout
ogrisel Sep 3, 2025
634ffcc
skip test only on CI
ogrisel Sep 3, 2025
e1524d3
Merge branch 'main' into faulthandler-exit-on-timeout
ogrisel Sep 9, 2025
fbce039
Trigger CI
ogrisel Sep 9, 2025
ea99722
Skip the new test on ubuntu-py314
ogrisel Sep 9, 2025
cfa2aa6
Actually skip the new test on ubuntu-py314
ogrisel Sep 9, 2025
136b515
Trigger CI
ogrisel Sep 9, 2025
d752ce9
Trigger CI
ogrisel Sep 9, 2025
5799868
Merge branch 'main' into faulthandler-exit-on-timeout
ogrisel Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "Skip flakky CI tests" 
This reverts commit be4f0ba.
  • Loading branch information
@ogrisel
ogrisel committed Aug 27, 2025
commit 5066d988dbd37a7fbaf4e55463ae2ad8ce5294c4
18 changes: 8 additions & 10 deletions testing/test_faulthandler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
from __future__ import annotations

import io
import os
import sys

from _pytest.pytester import Pytester
Expand Down Expand Up @@ -71,20 +72,15 @@ def test_disabled():
assert result.ret == 0


@pytest.mark.parametrize(
"enabled",
[
pytest.param(
True, marks=pytest.mark.skip(reason="sometimes crashes on CI (#7022)")
),
False,
],
)
@pytest.mark.parametrize("enabled", [True, False])
def test_timeout(pytester: Pytester, enabled: bool) -> None:
"""Test option to dump tracebacks after a certain timeout.

If faulthandler is disabled, no traceback will be dumped.
"""
if enabled and "CI" in os.environ:
pytest.xfail(reason="sometimes crashes on CI (#7022)")

pytester.makepyfile(
"""
import os, time
Expand All @@ -110,10 +106,12 @@ def test_timeout():
assert result.ret == 0


@pytest.mark.skip(reason="sometimes crashes on CI (#7022)")
@pytest.mark.parametrize("exit_on_timeout", [True, False])
def test_timeout_and_exit(pytester: Pytester, exit_on_timeout: bool) -> None:
"""Test option to force exit pytest process after a certain timeout."""
if "CI" in os.environ:
pytest.xfail(reason="sometimes crashes on CI (#7022)")

pytester.makepyfile(
"""
import os, time
Expand Down