Skip to content

Fix broken approx when mixing numpy booleans and booleans #13338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicoddemus merged 10 commits into from
Apr 2, 2025
Merged

Fix broken approx when mixing numpy booleans and booleans #13338

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
37367f9
Fix for issue #13047
BahramF73 Mar 31, 2025
f58bd36
Update changelog/13047.bugfix.rst
BahramF73 Apr 1, 2025
feac0be
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 1, 2025
68af923
Merge branch 'main' into fix-issue-13047
BahramF73 Apr 1, 2025
c59fd5a
Add tests for numpy booleans
BahramF73 Apr 1, 2025
10dfe37
Update approx.py
nicoddemus Apr 1, 2025
4d407c3
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 1, 2025
996c27b
Add more explanation to 13047.bugfix.rst
BahramF73 Apr 1, 2025
e14787a
Improve changelog
nicoddemus Apr 1, 2025
e81028e
Fix code-block in changelog
nicoddemus Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[pre-commit.ci] auto fixes from pre-commit.com hooks 
for more information, see https://pre-commit.ci
  • Loading branch information
@pre-commit-ci
pre-commit-ci[bot] committed Apr 1, 2025
commit feac0be3000426a357f7a23c5509a709cf2ea535
2 changes: 1 addition & 1 deletion changelog/13047.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
* Fixed an issue in equality checks where `bool` and `numpy.bool_` types were not handled consistently.
* Fixed an issue in equality checks where `bool` and `numpy.bool_` types were not handled consistently.
Comment thread
BahramF73 marked this conversation as resolved.
Outdated