Skip to content

WIP| Data driven reductors #2490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ftschindler wants to merge 36 commits into
base: main
Choose a base branch
from
Draft

WIP| Data driven reductors #2490

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
5299aa8
first draft of BlackBoxModel and NumpyBlackBoxModel
ftschindler May 22, 2025
6847343
algorithms.error| allow disabling of status printing and return fig
ftschindler May 22, 2025
7b9713b
add first draft of BestApproximationReductor
ftschindler May 22, 2025
2c87e51
add first draft of VkogaStateReductor
ftschindler May 23, 2025
38e1673
fix infinite recursion in NumpyBlackBoxModel
ftschindler May 26, 2025
88b3296
fix non-blocked case in BestApproximationReductor
ftschindler May 26, 2025
98c4e76
add scaling to VkogaStateReductor
ftschindler May 26, 2025
3560f92
add TODO to BlackBoxModel
ftschindler May 27, 2025
d73a305
allow to specify kernel for VkogaStateReductor
ftschindler May 27, 2025
8bbaa78
refactor BlackBoxModel to allow arbitrary computers
ftschindler Jun 4, 2025
87286a4
keep fitted estimators in VkogaStateReductor
ftschindler Jun 4, 2025
cf82504
rename BlackBoxModel -> ComputeModel
ftschindler Jun 5, 2025
4f24023
add DataSet
ftschindler Jun 18, 2025
d352f81
dataset| allow derived classes to specify dump/load
ftschindler Jun 20, 2025
e15dc90
dataset| add debug logging
ftschindler Jun 23, 2025
cfa6b0c
DataSet | Changed for ArrayLike to np.ndarray for DataSet.add type check
ftschindler Jul 4, 2025
c69e780
dataset| add to_model()
ftschindler Jul 8, 2025
4878544
rename ComputeModel -> GenericModel
ftschindler Nov 13, 2025
deee6a5
Revert "fix non-blocked case in BestApproximationReductor"
ftschindler Nov 13, 2025
d833c48
Revert "add first draft of BestApproximationReductor"
ftschindler Nov 13, 2025
ccb33de
examples| add BestApproximationReductor
ftschindler Oct 20, 2024
c23c944
examples| set rom name in BestApproximationReductor
ftschindler Oct 22, 2024
6b2e3eb
examples| rebase BestApproximationReductor onto ProjectionBasedReductor
ftschindler Oct 22, 2024
b494032
examples| silence rom after BestApproximationReductor
ftschindler Oct 23, 2024
6b55d38
examples| use ComputeModel in BestApproximationReductor
ftschindler Jul 8, 2025
95d4c14
reductors| update BestApproximationReductor
ftschindler Sep 2, 2025
ad7662f
reductors| rename BestApproximationReductor -> OrthogonalProjectionRe…
ftschindler Nov 13, 2025
fd2be5d
models| apply ComputeModel -> GenericModel use
ftschindler Nov 13, 2025
f9fb0ca
reductors| add first draft of ScikitLearnComputeReductor
ftschindler Jun 4, 2025
10e8e67
reductors| add custom model + sorting to SkLearn reductor
ftschindler Nov 18, 2025
d23aa11
reductors| change kernel switching in VKOGAEstimator
ftschindler Nov 18, 2025
98e4f32
Update typo in Sklearn reductor
ftschindler Jul 9, 2025
0532880
Add hparam tuning to Sklearn reductor
ftschindler Jul 9, 2025
5feb166
reductors| use GenericModel
ftschindler Nov 14, 2025
5711e6e
drop VkogaStateReductor
ftschindler Nov 18, 2025
3f3bf17
reductors| sklearn -> data_driven
ftschindler Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
models| apply ComputeModel -> GenericModel use
  • Loading branch information
@ftschindler
ftschindler committed Nov 18, 2025
commit fd2be5dfdd6676a1dd192c45da71132d9f953832
2 changes: 1 addition & 1 deletion src/pymor/core/dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from pymor.core.base import BasicObject
from pymor.core.cache import build_cache_key
from pymor.core.pickle import dump, load
from pymor.models.compute import ComputeModel
from pymor.models.generic import ComputeModel
from pymor.parameters.base import Parameters
from pymor.vectorarrays.interface import VectorArray

Expand Down
4 changes: 2 additions & 2 deletions src/pymor/reductors/orthogonal_projection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

from pymor.core.defaults import defaults
from pymor.models.interface import Model
from pymor.models.compute import ComputeModel
from pymor.models.generic import GenericModel
from pymor.reductors.basic import ProjectionBasedReductor
from pymor.vectorarrays.interface import VectorArray
from pymor.vectorarrays.numpy import NumpyVectorSpace
Expand Down Expand Up @@ -56,7 +56,7 @@ def project_onto_basis(U):
return np.linalg.solve(G, R).T

rom_space = NumpyVectorSpace(dim)
rom = ComputeModel(
rom = GenericModel(
parameters=self.fom.parameters,
computers={
"solution": (
Expand Down