Add debug openapi commands#384
Merged
Merged
Conversation
mdellweg
force-pushed
the
debug_openapi
branch
from
3317164 to
fc1b14c
Compare
mdellweg
force-pushed
the
debug_openapi
branch
3 times, most recently
from
36c8da7 to
fa2abba
Compare
mdellweg
commented
Oct 4, 2021
ggainey
reviewed
Oct 4, 2021
Contributor
ggainey
left a comment
ggainey
left a comment
There was a problem hiding this comment.
I like this a lot!
The older tests are failing because 'canceling' wasn't added to pulpcore until 0e1c62, but pulp-cli "knows about it". What can we do about that?
mdellweg
force-pushed
the
debug_openapi
branch
from
fa2abba to
38f3493
Compare
[noissue]
mdellweg
force-pushed
the
debug_openapi
branch
from
38f3493 to
5c9807d
Compare
Member
Author
|
@ggainey removed the jq idea for now. |
Contributor
Oh - I didn't mean to ask that the jq-work be removed from here, so much as "don't do the global-option as part of this PR". But it's prob better to fully-separate the two. Looks good - do we wait for the ansible PR to merge and a clean run before merging here? |
Member
Author
|
I don't see a reason to wait. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.