Bypass chunked uploading if chunk size exceeds file size#262
Merged
Conversation
daviddavis
force-pushed
the
fix262
branch
2 times, most recently
from
3607ecd to
8098316
Compare
Contributor
Author
|
I'm debating about adding an explicit option to also bypass chunk uploading. Wdyt @mdellweg ? |
Member
Then i would argue, that we'd need a force-chunks option, because large files only work as chunks. I wouldn't do either without anyone asking for it. |
mdellweg
reviewed
Jun 7, 2021
daviddavis
commented
Jun 9, 2021
| READ_ID = "artifacts_read" | ||
| CREATE_ID = "artifacts_create" | ||
|
|
||
| def upload(self, file: IO[bytes], chunk_size: int = 1000000, check_exists: bool = True) -> Any: |
Contributor
Author
There was a problem hiding this comment.
We're not using check_exists=False anywhere and maintaining it was making the code more and more complex.
daviddavis
force-pushed
the
fix262
branch
2 times, most recently
from
cd2d888 to
a8c8a03
Compare
mdellweg
reviewed
Jun 11, 2021
daviddavis
force-pushed
the
fix262
branch
3 times, most recently
from
27b08e2 to
bc80a40
Compare
mdellweg
approved these changes
Jun 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[noissue]