Skip to content

Add signing service inspection commands#189

Merged
mdellweg merged 1 commit into
pulp:developfrom
mdellweg:signing
Apr 28, 2021
Merged

Add signing service inspection commands#189
mdellweg merged 1 commit into
pulp:developfrom
mdellweg:signing

Conversation

@mdellweg

Copy link
Copy Markdown
Member

fixes #TBA

@mdellweg

mdellweg commented Mar 29, 2021

Copy link
Copy Markdown
Member Author

I want to find a way to make this testable before merging.
It is now.

mdellweg added a commit to mdellweg/pulp-cli that referenced this pull request Apr 1, 2021
@mdellweg mdellweg force-pushed the signing branch 5 times, most recently from b4366a7 to d2f7593 Compare April 1, 2021 18:33
@mdellweg mdellweg marked this pull request as ready for review April 1, 2021 20:13
@mdellweg mdellweg added this to the 0.8.0 milestone Apr 2, 2021

@ggainey ggainey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we detach the import/export changes from this PR? Otherwise, this looks great!

Comment thread pulpcore/cli/core/context.py Outdated

class PulpExporterContext(PulpEntityContext):
ENTITY = "PulpExporter"
ENTITY = "pulp exporter"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to be part of this PR?

Comment thread pulpcore/cli/core/context.py Outdated
Comment thread pulpcore/cli/core/context.py Outdated
Comment thread tests/assets/setup_signing_service.py
Comment thread tests/assets/sign_deb_release.sh

@ggainey ggainey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mdellweg mdellweg merged commit 70c6a76 into pulp:develop Apr 28, 2021
@mdellweg mdellweg deleted the signing branch April 28, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants