[pull] main from firecracker-microvm:main#608
Merged
Conversation
check_guest_connections fires TEST_CONNECTION_COUNT (50) concurrent guest->host connects, but host_echo_server listened with backlog=5. The vsock muxer establishes the host-side connection with a blocking connect() on the VMM event-loop thread; when the backlog saturates (the whole worker burst reconnecting at once after a snapshot restore), that connect() stalls the VMM and delays OP_RESPONSEs past the guest's 2s vsock connect timeout, causing intermittent "connect(): timed out" failures in test_cycled_snapshot_restore. Use the existing SERVER_ACCEPT_BACKLOG (128) so the backlog comfortably exceeds the concurrent connection count, matching the guest-side listener. Signed-off-by: Riccardo Mancini <mancio@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )