Skip to content

feat: convert PostHTML to TypeScript and Es Modules #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aminya wants to merge 15 commits into
base: master
Choose a base branch
from
Open

feat: convert PostHTML to TypeScript and Es Modules #396

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
9165556
feat: convert PostHTML to Es Modules
aminya Oct 15, 2023
e576af5
fix: fix the esm import extensions
aminya Oct 15, 2023
5b1aa3d
fix: avoid assignments to imports
aminya Oct 15, 2023
bc9e0f6
fix: fix unused argument errors for eslint
aminya Oct 15, 2023
914755e
fix: replace JSON import with JSON.parse for ESM
aminya Oct 15, 2023
47b0511
fix: fix Api extension for ES modules
aminya Oct 16, 2023
0c288ec
test: fix usage of __dirname in the tests for Es Modules
aminya Oct 16, 2023
ff24a06
test: add Commonjs backwards compatibility test
aminya Oct 16, 2023
31a3093
fix: transform import.meta for cjs files
aminya Oct 16, 2023
0a78e28
fix: add module.exports for cjs compatibility
aminya Oct 16, 2023
7088a0e
feat: convert to TypeScript
aminya Oct 19, 2023
0372b6e
fix: fix the types of PostHTML and its methods
aminya Oct 19, 2023
7a1a28a
fix: fix the types of NodeAPI
aminya Oct 19, 2023
8de2e0e
test: import the built files in the tests
aminya Oct 19, 2023
fd34a7a
build: enable more TypeScript checks
aminya Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: add Commonjs backwards compatibility test
  • Loading branch information
@aminya
aminya committed Oct 16, 2023
commit ff24a0695da5b3168a1f6586a68821b1cf330afc
1 change: 1 addition & 0 deletions .eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"ignorePatterns": ["lib/*.cjs"],
"parser": "@babel/eslint-parser",
"rules": {
"import/no-commonjs": "error",
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
"prepare": "husky install && npm run build",
"version": "conventional-changelog -i changelog.md -s -r 0 && git add changelog.md",
"lint": "eslint --fix lib/*.mjs test/*.mjs",
"test": "npm run lint && c8 mocha",
"test": "npm run build && npm run lint && c8 mocha",
"docs:api": "jsdoc2md lib/api.js > docs/api.md",
"docs:core": "jsdoc2md lib/index.js > docs/core.md"
},
Expand Down
24 changes: 24 additions & 0 deletions test/test.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
/* eslint-disable import/no-commonjs */

const { it, describe } = require('mocha')
const { expect } = require('chai')

const posthtml = require('../lib/index.cjs')

const input = '<div class="button"><div class="button__text">Text</div></div>'

function test (html, done) {
posthtml()
.process(html)
.then(result => {
expect(input).to.eql(result.html)
done()
})
.catch(error => done(error))
}

describe('[Commonjs] Simple text', () => {
it('html eqval', done => {
test(input, done)
})
})