Rename Packages pane enable setting to packages.enabled#13642
Conversation
Adds packages.enabled as the canonical setting and hides the old positron.packages.enable behind included:false + a deprecationMessage. Both keys are honored: the pane is hidden if either is set to false, so existing user settings.json files keep working with no migration. See #13349
|
E2E Tests 🚀 |
| export const POSITRON_PACKAGES_VIEW_CONTAINER_ID = 'workbench.viewContainer.positronPackages'; | ||
|
|
||
| const POSITRON_PACKAGES_ENABLED = ContextKeyExpr.equals('config.positron.packages.enable', true); | ||
| const POSITRON_PACKAGES_ENABLED = ContextKeyExpr.and( |
There was a problem hiding this comment.
Should this be an OR instead of an AND check? IIUC config.positron.packages.enable is the old setting name and we are keeping it around until this feature is out of preview (so folks who are already using it don't need to update their settings file) but the new setting name we want new folks to use is config.packages.enabled. If either is enabled, a user should be able to use the packages pane, right? Or do both need to be explicitly set to use the feature?
There was a problem hiding this comment.
As long as both are defined and default to true, AND seems correct. Eventually the old setting will be removed.
There was a problem hiding this comment.
Ah yep, I got myself confused before but I think we should do AND so that, at least for the time being, if someone opted out before with the old setting we still opt them out.
softwarenerd
left a comment
softwarenerd
left a comment
There was a problem hiding this comment.
I think makes sense for use to keep the config.positron.packages.enable defined and defaulted to true because some user's may have set it to false. And the new setting config.packages.enabled is also defaulted to true.
juliasilge
left a comment
juliasilge
left a comment
There was a problem hiding this comment.
Thank you! I'm glad we can get this fixed now before too much time has passed so we don't add this setting to the list of ones we need to address with #13354.
bricestacey
dismissed stale reviews from jmcphers, juliasilge, and softwarenerd
via
b66daa9
…ages.contribution.ts Co-authored-by: Julia Silge <julia.silge@gmail.com> Signed-off-by: Brice Stacey <bricestacey@gmail.com>
5 participants
Adds
packages.enabledas the canonical setting and hides the oldpositron.packages.enablebehind included:false and a deprecationMessage. Both keys are honored: the pane is hidden if either is set to false, so existing user settings.json files keep working with no migration.See #13349
This is the second time we're renaming this key, so would like to get a strong upvote on the configuration name.