Refactor Packages Pane to use PositronList component#13556
Merged
Conversation
Replaces react-window's FixedSizeList in the packages pane with the shared PositronListInstance / PositronList component. Selection, keyboard navigation, scroll persistence, and empty-state are now delegated to the list framework instead of hand-rolled React state.
|
E2E Tests 🚀 |
softwarenerd
previously approved these changes
May 20, 2026
Contributor
softwarenerd
left a comment
softwarenerd
left a comment
There was a problem hiding this comment.
Approved. I've pushed a flex layout improvement.
Override selectRow so the focus outline tracks the selected row. The base DataGridInstance.selectRow only sets _rowSelectionIndexes, which is right for a grid where cursor and selection are independent but wrong for a list where the focused row should be the selected row. Section rows are no-ops since they aren't selectable.
This was left behind after the mouseSelectCell override was removed in favor of the selectRow override. CI's TS6133 lint blocked compile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the packages pane to use the new PositronList.
We want to do this for a variety of reasons, but it also fixes known scroll issues on web.
See: #12964
This PR is mostly ready, but there are known issues with PositronList that are blocking merge. Specifically:
Release Notes
New Features
Bug Fixes
Validation Steps
The behavior of the pane should be pretty consistent with its previous behavior. A couple of areas to note:
@:packages-pane