Fix macOS Intel compatibility: respect npm_config_arch#13375
Merged
Conversation
|
E2E Tests 🚀 |
Collaborator
Author
|
Notes for reviewer:
|
melissa-barca
approved these changes
May 5, 2026
Contributor
melissa-barca
left a comment
melissa-barca
left a comment
There was a problem hiding this comment.
Ah, this is a bad one. Thanks - lgtm!
I didn't test any of the builds, but I downloaded both binaries and confirmed the correct or universal build of the bootstrapped extensions, pet, ark, and kallichore. I did not check the linux (pet) or windows (ark) builds so it's worth double checking those once we have builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building for macOS Intel processors, we set
npm_config_archto the intended architecture; since all our build infrastructure is on Apple Silicon,arch()is alwaysarm64, and we relynpm_config_archto select binaries that are architecture-dependent.There are a few places where we were still relying on
arch(). This was never a problem before because we selected (or created) universal binaries, but now that we don't have a universal build it is vital to respectnpm_config_archwhen selecting binaries.Closes #13372
Closes #13369