-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Share chart button #7802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Share chart button #7802
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
42c9601
add button placeholder which shows chart JSON
emilykl 8ce5512
add icon
emilykl ad9ddfc
use existing sendChartToCloud function
emilykl 100da7b
update plot-schema
emilykl 82f5437
Update approach to use postMessage and wait for ready signal before s…
marthacryan fddd50e
Merge branch 'master' of github.com:plotly/plotly.js into upload-to-c…
marthacryan ba91b11
Create a confirmation dialog
marthacryan 717fc26
Add default URL for plotlyServerURL
marthacryan 8774b9c
Update string to indicate success
marthacryan 13b8f12
Update src/plot_api/plot_config.js
marthacryan a44f6ef
Add localization
marthacryan 836d24c
Address review
marthacryan 1f47ebd
Update default cloud URL
marthacryan 83deac2
Update src/components/modebar/cloud_confirm.js
marthacryan 852dc1f
Set default to false for showSendToCloud
marthacryan 4a71e43
Merge changes
marthacryan ff34976
Update plot-schema in dist
marthacryan e5933bd
Revert "Update plot-schema in dist"
emilykl c1b7122
update test/plot-schema.json
emilykl c28c434
Update default URL for upload to empty string until plotly cloud endp…
marthacryan da868be
Merge branch 'upload-to-cloud-proto' of github.com:plotly/plotly.js i…
marthacryan bf8971a
Update src/components/modebar/cloud_confirm.js
marthacryan ada548c
Update src/components/modebar/buttons.js
marthacryan 0ee9501
Move validation logic to prevent dialog opening for invalid URLs
marthacryan 299d9a5
Merge branch 'upload-to-cloud-proto' of github.com:plotly/plotly.js i…
marthacryan 5a7a7af
Update default for test plot schema
marthacryan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add default URL for plotlyServerURL
- Loading branch information
commit 717fc265d77f5f5b4e6ccde178b5fb7b8f2e3213
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.