-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Add support for dashed marker lines in scatter plots #7673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
camdecoster
merged 31 commits into
plotly:master
from
chrimaho:feature-marker-line-dash-7667
Feb 2, 2026
Merged
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
de99bdc
Add support for dashed marker lines in scatter plots
chrimaho 8c1fdf2
Add changelog entry for dashed marker line support
chrimaho d838891
Add dash attribute support to marker lines across scatter trace types
chrimaho 0df71bb
Hide marker line for blank points in scatter plots
chrimaho 26eecd9
Add dash style property to marker line schemas
chrimaho 6ce3af4
Fix failing CI for `text_on_shapes_basic` pixel comparison
chrimaho 753c6ed
Simplify stroke styling and remove unused dash line logic
chrimaho 6de355d
update plot-schema diff
chrimaho 8573067
Revert `plot-schema` to version from `master` branch
chrimaho 6fa75bc
Remove `arrayOk` attribute from the `marker.line` attribute of the `s…
chrimaho ac01dc3
Remove `marker.line.dash` changes from the `scatter3d`, `scattergl`, …
chrimaho f348454
Implement logic to actually draw the dashed lines
chrimaho f733505
Fix missing end of file newline
chrimaho 3dd16f7
Add `arrayOk` attribute to `marker.line.dash` for scatter plots.
chrimaho 7eb1943
Add tests and mock data for scatter marker line dash support
chrimaho 90ab105
Update `plot-schema` diff
chrimaho e8a702d
Rename test file
camdecoster cddc465
Update mock layout
camdecoster 67458e7
Linting/formatting
camdecoster 65a0d87
Don't coerce marker.line.dash for some traces
camdecoster 5fbbac5
Enable dash styles for open markers
camdecoster 05e851f
Update mock styles
camdecoster 869367e
Fix failing test
camdecoster 9361e7e
Add basline image for mock
camdecoster 6a3273e
Merge remote-tracking branch 'origin/master' into feature-marker-line…
camdecoster d4d4972
Update baseline image per PR changes
camdecoster ebdb604
Update draftlog
camdecoster cbd4dd2
Linting/formatting
camdecoster f7f9714
Revert "Update baseline image per PR changes"
camdecoster 2edd723
Don't use dash in legend markers for shape traces
camdecoster f698f6b
Add test to check for shape legend marker dashes
camdecoster File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Add support for dashed marker lines in scatter plots
- Enable `marker.line.dash` attribute in scatter trace definitions with support for array values - Apply dash patterns to marker outlines in both open and closed marker styles - Merge dash data into calcdata for per-point dash styling - Include dash information in legend marker rendering to match trace appearance - Default dash handling falls back to trace-level `marker.line.dash` when per-point values are not specified
- Loading branch information
commit de99bdc2fc44d293e4726c12363c444fbac39f7b
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This property already exists on the dash object, so it isn't needed here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 6fa75bc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You removed the wrong line.
arrayOk: trueis still needed.editType: 'style'should be removed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected in 3dd16f7