Add confirm_message to toggle-bool-switch#498
Merged
Conversation
Contributor
Author
|
@difernandez, could you check it? |
mpapis
reviewed
Aug 28, 2024
mpapis
left a comment
mpapis
left a comment
Contributor
There was a problem hiding this comment.
As I had use case to confirm only turning off - so extended with confirmation separately on or off.
rjherrera
reviewed
Sep 10, 2024
rjherrera
left a comment
rjherrera
left a comment
Member
There was a problem hiding this comment.
thanks for the PR and sorry for the long wait. I suggested something as I was worried about the implementation, let me know so we can merge this :)
Co-authored-by: Michal Papis <mpapis@gmail.com>
Co-authored-by: Raimundo Herrera <rjherrera@uc.cl>
rjherrera
reviewed
Sep 13, 2024
rjherrera
left a comment
rjherrera
left a comment
Member
There was a problem hiding this comment.
i left the suggestions there
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Add new confirm_message feature to toggle-bool-switch: #483