Fix searching for ids with selected list input#489
Merged
Conversation
a7f7217 to
24d9ac0
Compare
rjherrera
approved these changes
Sep 10, 2024
rjherrera
left a comment
Member
There was a problem hiding this comment.
long overdue review, sorry about that, this looks good, thanks for the PR
24d9ac0 to
2ad5ab9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Background
id, other searchable inputs force thepredicatetoeqrather thancont, andselected-listdoes not, which results in a SQL error.Detail
This Pull Request changes the
predicatetoeqwhen the field isid.Additional information
From:
To:
Checklist
Before submitting the PR make sure the following are checked: