V1 backport ActiveAdmin v3 support and release new version#479
Merged
difernandez merged 7 commits intoAug 24, 2023
Conversation
Now required in AA v3 / Ransack v4
monkeyci
reviewed
Aug 23, 2023
Mainly, the 'contains' predicate, that was used as default in some components. These predicates were removed from activeadmin v3, since they were backports. More info here activeadmin/activeadmin#8010
We wont't require ruby 3 just yet, but for testing purposes we need to remove it
Backports AA v3 support
difernandez
force-pushed
the
v1-backport-AA-v3-support-and-release-new-version
branch
from
aadc069 to
9bed815
Compare
This was referenced Aug 23, 2023
Merged
ldlsegovia
approved these changes
Aug 24, 2023
difernandez
deleted the
v1-backport-AA-v3-support-and-release-new-version
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created because in #477 we made some changes in order for this gem to be compatible with the recently released AA v3, but those changes are, as of now, only available in v2 (now in beta) of this gem. Even though we won't be supporting or backporting features to v1, we think it would be good to backport this particular changes to increase overall compatibility.
Detail
This Pull Request backports said changes in #477 to support v3 of ActiveAdmin in v1 of this gem. Also, in order, for tests to pass, needed to update to most recent ruby and also backport #476 to fix the webdriver issues, and remove EOL rubies from the CI.
Additional information
Checklist
Before submitting the PR make sure the following are checked: