Activeadmin v3 support#477
Merged
Merged
Conversation
monkeyci
reviewed
Aug 3, 2023
Now required in AA v3 / Ransack v4
Mainly, the 'contains' predicate, that was used as default in some components. These predicates were removed from activeadmin v3, since they were backports. More info here activeadmin/activeadmin#8010
difernandez
force-pushed
the
activeadmin-v3-support
branch
from
d838ab2 to
faea79f
Compare
ldlsegovia
approved these changes
Aug 7, 2023
| self.state ||= 'pending' | ||
| end | ||
|
|
||
| def self.ransackable_attributes(_auth_object = nil) |
Contributor
There was a problem hiding this comment.
I understand that now it is mandatory to do this, right?
Contributor
|
Can we get a release of this before the whole v2 overhaul? |
6 tasks
Contributor
Author
|
@jgmontoya even though we won't be backporting things to v1, this seems important enough that we can release it for a last v1 update. I opened #479 for this, so we should be releasing that in the short run |
Contributor
Author
|
@jgmontoya we just released v1.10.1 , please let us know how it goes if you try it out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created because ActiveAdmin released v3 🎉 . It has some breaking changes, including requiring of ransack v4, so some changes needed to be done on our part to support it.
Detail
This Pull Request applies a couple of backwards compatible changes that allow this gem to work well with AA v3, and for tests to pass using that version:
ransackable_attributesandransackable_associationsto dummy app models, as it is now explicitly required by ransack v4contains), that are now removed from AA. These predicates were backports in AA, and they have been replaced by their already existent Ransack equivalentsAdditional information
Closes #475
Checklist
Before submitting the PR make sure the following are checked: