Remove enumerize#452
Merged
Merged
Conversation
monkeyci
reviewed
Mar 17, 2023
difernandez
suggested changes
Mar 17, 2023
difernandez
left a comment
difernandez
left a comment
Contributor
There was a problem hiding this comment.
Couple small things, looks good!
Comment on lines
+5
to
+8
| :enumerize | ||
| elsif rails_enum_attr? | ||
| @enum_attr = if rails_enum_attr? | ||
| :enum | ||
| end | ||
|
|
||
| raise "you need to pass an enumerize or enum attribute" unless @enum_attr | ||
| raise "you need to pass an enum attribute" unless @enum_attr |
Contributor
There was a problem hiding this comment.
with the change in display_data, @enum_attr is no longer used. We could chage this to just:
raise "you need to pass an enum attribute" unless rails_enum_attr?
Contributor
There was a problem hiding this comment.
this whole file was for enumerize support, we should just delete it
difernandez
approved these changes
Mar 17, 2023
ldlsegovia
approved these changes
Mar 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Platanus we have transitioned to using the standard Rails enums, which means that we are unable to continue supporting enumerize in this gem.