Shrine images#396
Merged
Merged
Conversation
gmq
reviewed
Apr 4, 2022
gmq
reviewed
Apr 8, 2022
GabrielLyonB
force-pushed
the
shrine-images
branch
from
8a95399 to
98c8c00
Compare
gmq
approved these changes
Apr 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
ImageBuilderto allow the use of shrine images.Description
shrineandimage_processingas a developer dependency.picture_datacolumn in theInvoicemodelo to try the shrine image uploader.ImageBuildera case for shrine objects. This includes the use of derivatives.ImageBuilderbased on the tests for paperclip.