Skip to content

Fix phpstan/phpstan#12686: Unable to mark an anonymous function as impure #5348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VincentLanglet merged 5 commits into from
Mar 30, 2026
Merged

Fix phpstan/phpstan#12686: Unable to mark an anonymous function as impure #5348

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dbdc192
Fix phpstan/phpstan#12686: Respect closure purity in type narrowing
github-actions[bot] Mar 30, 2026
2464761
Add tests for multiple callable parameter acceptors purity check
phpstan-bot Mar 30, 2026
93e1e21
Add regression tests for phpstan/phpstan#3770 and phpstan/phpstan#6822
phpstan-bot Mar 30, 2026
b788e4e
Add rule test for phpstan/phpstan#6822 to prove no false-positive rul…
phpstan-bot Mar 30, 2026
a811e24
Reuse nsrt/bug-6822.php for rule test instead of separate data file
phpstan-bot Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Reuse nsrt/bug-6822.php for rule test instead of separate data file 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
  • Loading branch information
@phpstan-bot @claude
phpstan-bot and claude committed Mar 30, 2026
commit a811e244ec7915c7ba64eeaab139aba067efa309
8 changes: 8 additions & 0 deletions tests/PHPStan/Analyser/nsrt/bug-6822.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@

if ($closure()) {
assertType('bool', $closure());

if ($closure()) { // should not be reported as "always true"
echo 'yes';
}
}

// Same with an explicit impure closure assigned to a variable
Expand All @@ -25,4 +29,8 @@

if ($impureFn() > 50) {
assertType('int<0, 100>', $impureFn());

if ($impureFn() > 50) { // should not be reported as "always true"
echo 'yes';
}
}
2 changes: 1 addition & 1 deletion tests/PHPStan/Rules/Comparison/IfConstantConditionRuleTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ public function testBug4284(): void
public function testBug6822(): void
{
$this->treatPhpDocTypesAsCertain = true;
$this->analyse([__DIR__ . '/data/bug-6822.php'], []);
$this->analyse([__DIR__ . '/../../Analyser/nsrt/bug-6822.php'], []);
}

}
25 changes: 0 additions & 25 deletions tests/PHPStan/Rules/Comparison/data/bug-6822.php
View file
Open in desktop

This file was deleted.

Loading