Skip to content

8379873: Remove undefined debugging declarations in os_windows.cpp#30428

Closed
dev-jonghoonpark wants to merge 1 commit into
openjdk:masterfrom
dev-jonghoonpark:JDK-8379873
Closed

8379873: Remove undefined debugging declarations in os_windows.cpp#30428
dev-jonghoonpark wants to merge 1 commit into
openjdk:masterfrom
dev-jonghoonpark:JDK-8379873

Conversation

@dev-jonghoonpark

@dev-jonghoonpark dev-jonghoonpark commented Mar 25, 2026 •
edited by openjdk Bot
Loading

Copy link
Copy Markdown
Contributor

changes

  • Remove undefined debugging declarations in os_windows.cpp
    • void safepoints();
    • void find(int x);
    • void events();

Test

  • Verified that make images completes without errors.
  • Confirmed that Tier1 tests pass successfully.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8379873: Remove undefined debugging declarations in os_windows.cpp (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30428/head:pull/30428
$ git checkout pull/30428

Update a local copy of the PR:
$ git checkout pull/30428
$ git pull https://git.openjdk.org/jdk.git pull/30428/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30428

View PR using the GUI difftool:
$ git pr show -t 30428

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30428.diff

Using Webrev

Link to Webrev Comment

@dev-jonghoonpark
Remove undefined debugging declarations in os_windows.cpp
898f05f 
Signed-off-by: jonghoonpark <dev@jonghoonpark.com>
@bridgekeeper

bridgekeeper Bot commented Mar 25, 2026

Copy link
Copy Markdown

👋 Welcome back dev-jonghoonpark! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Mar 25, 2026 •
edited
Loading

Copy link
Copy Markdown

@dev-jonghoonpark This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8379873: Remove undefined debugging declarations in os_windows.cpp

Reviewed-by: dholmes, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 34 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dholmes-ora, @albertnetymk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk Bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Mar 25, 2026
@openjdk

openjdk Bot commented Mar 25, 2026

Copy link
Copy Markdown

@dev-jonghoonpark The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Mar 25, 2026
@mlbridge

mlbridge Bot commented Mar 25, 2026

Copy link
Copy Markdown

Webrevs

dholmes-ora
dholmes-ora approved these changes Mar 26, 2026
View reviewed changes

@dholmes-ora dholmes-ora left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial. This was literally "day one" code.

@openjdk openjdk Bot added the ready Pull request is ready to be integrated label Mar 26, 2026
@dev-jonghoonpark

dev-jonghoonpark commented Mar 26, 2026

Copy link
Copy Markdown
Contributor Author

/integrate

@openjdk openjdk Bot added the sponsor Pull request is ready to be sponsored label Mar 26, 2026
@openjdk

openjdk Bot commented Mar 26, 2026

Copy link
Copy Markdown

@dev-jonghoonpark
Your change (at version 898f05f) is now ready to be sponsored by a Committer.

@dholmes-ora

dholmes-ora commented Mar 30, 2026

Copy link
Copy Markdown
Member

/sponsor

@openjdk

openjdk Bot commented Mar 30, 2026

Copy link
Copy Markdown

Going to push as commit eb96bfb.
Since your change was applied there have been 64 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk Bot added the integrated Pull request has been integrated label Mar 30, 2026
@openjdk openjdk Bot closed this Mar 30, 2026
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 30, 2026
@openjdk

openjdk Bot commented Mar 30, 2026

Copy link
Copy Markdown

@dholmes-ora @dev-jonghoonpark Pushed as commit eb96bfb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@albertnetymk albertnetymk albertnetymk approved these changes
@dholmes-ora dholmes-ora dholmes-ora approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dev-jonghoonpark @dholmes-ora @albertnetymk