Why not, it's probably the right fix. But let's hold on with merging until the issue is fully understood.

Still need to check that NumpyVersion in scipy doesn't break.

Note: Unless the person has setuptools 8+ installed tools like wheel and setup.py sdist will normalize this to dev-<foo> like before.

OK I think we can merge this. @argriffing would you mind adding some explanation to the commit message? Might be useful later on.

adding some explanation to the commit message

OK, added

Thanks. Going to hit the merge button in the morning unless someone stops me.

LGTM too. Might as well get it in now...

Could someone send a quick heads up to the making list with an example of a
"before" and "after" version number? Not a big deal but there are probably
people who are matching thee version number with a regex somewhere who
would appreciate the warning.
On 24 Dec 2014 01:20, "Charles Harris" notifications@github.com wrote:

Merged #5387 #5387.

—
Reply to this email directly or view it on GitHub
#5387 (comment).

does this work with NumPyVersion or do we have to put fixes into the 0.14.1 and 1.9.2?

tests succeed if one replaces dev- with dev+ so numpy should be good

NumpyVersion is not affected.

@njsmith good idea, I'll send an email now.

Should probably be mentioned in the 1.10 release notes.

@charris good point, done in gh-5402.