ENH: use PyMem_RawMalloc instead of system allocator for better performance on free-threading#31503
Merged
Merged
Conversation
…rmance on free-threading
ngoldbaum
approved these changes
May 26, 2026
Member
ngoldbaum
left a comment
ngoldbaum
left a comment
There was a problem hiding this comment.
Overall looks good. I'm approving because this is mergeable as-is but I also have some small followup suggestions:
- Can you add a release note fragment that we are using
PyMem_RawMallocfor internal allocators that this will show up intracemallocstatistics? - Claude points out that you missed the uses in
_simd_convert.inc:
@charris are you OK with backporting this to the 2.5 branch with the release note? I don't think this is dangerous to backport and it'd be nice to include it with all the other free-threading scaling improvements for 2.5.
ngoldbaum
added
09 - Backport-Candidate
Member
|
I'm going to merge this to make sure it gets included in the 2.5.0rc1. Thanks @kumaraditya303! |
charris
pushed a commit
that referenced
this pull request
May 28, 2026
…rmance on free-threading (#31503)
charris
added a commit
that referenced
this pull request
May 28, 2026
ENH: use PyMem_RawMalloc instead of system allocator for better performance on free-threading (#31503)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Fixes #28454
This PR replaces usage of system allocator
mallocwithPyMem_RawMallocand friends for better performance on free-threading where mimalloc is used as the underlying allocator.AI Disclosure
I used Claude to find all the places where the replacement makes sense.