BUG: Any dtype should call square on arr ** 2 (#29392)#29417
Merged
Conversation
* BUG: update fast_scalar_power to handle special-case squaring for any array type except object arrays * BUG: fix missing declaration * TST: add test to ensure `arr**2` calls square for structured dtypes * STY: remove whitespace * BUG: replace new variable `is_square` with direct op comparison in `fast_scalar_power` function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #29392.
Fixes #29388.
The simplification in gh-27901 seems to have removed special casing for squares, not considering the differing behavior of
np.power(x, 2)andnp.square(x)on structured dtypes.There may be more edge cases to consider--I am looking! Also adding a test. Thanks.
BUG: update fast_scalar_power to handle special-case squaring for any array type except object arrays
BUG: fix missing declaration
TST: add test to ensure
arr**2calls square for structured dtypesSTY: remove whitespace
BUG: replace new variable
is_squarewith direct op comparison infast_scalar_powerfunction