Skip to content

BUG: fix data race in np.repeat #28209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charris merged 3 commits into from
Jan 21, 2025
Merged

BUG: fix data race in np.repeat #28209

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c1864a9
TST: remove unnecessary iters argument from run_threaded helper
ngoldbaum Jan 20, 2025
1451af2
TST: add failing test for multithreaded repeat
ngoldbaum Jan 20, 2025
cec8fbf
BUG: avoid data race in PyArray_Repeat
ngoldbaum Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
BUG: avoid data race in PyArray_Repeat
  • Loading branch information
@ngoldbaum @charris
ngoldbaum authored and charris committed Jan 21, 2025
commit cec8fbfbb8ad4fe3f5255336d35071adfe38c146
13 changes: 10 additions & 3 deletions numpy/_core/src/multiarray/item_selection.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -922,16 +922,23 @@ PyArray_Repeat(PyArrayObject *aop, PyObject *op, int axis)
}
}

/* Fill in dimensions of new array */
npy_intp dims[NPY_MAXDIMS] = {0};

for (int i = 0; i < PyArray_NDIM(aop); i++) {
dims[i] = PyArray_DIMS(aop)[i];
}

dims[axis] = total;

/* Construct new array */
PyArray_DIMS(aop)[axis] = total;
Py_INCREF(PyArray_DESCR(aop));
ret = (PyArrayObject *)PyArray_NewFromDescr(Py_TYPE(aop),
PyArray_DESCR(aop),
PyArray_NDIM(aop),
PyArray_DIMS(aop),
dims,
NULL, NULL, 0,
(PyObject *)aop);
PyArray_DIMS(aop)[axis] = n;
if (ret == NULL) {
goto fail;
}
Expand Down