BUG: Add object cast to avoid warning with limited API#26985
Merged
Conversation
To be honest, I think we should just delete this from the public API. But I thought I'll start with this, since at least in principle that isn't a bug-release thing to backport. I am not sure setting warnings to errors is wise (at least for Cython and MSVC). OTOH, the Cython module currently truly does nothing except include the headers (it doesn't even use the NumPy `.pyd` yet).
ngoldbaum
reviewed
Jul 19, 2024
Member
ngoldbaum
left a comment
ngoldbaum
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the expanded tests. Merging.
| 'limited_api_latest', | ||
| 'limited_api_latest.c', | ||
| c_args: [ | ||
| '-DNPY_NO_DEPRECATED_API=NPY_1_21_API_VERSION', |
Member
There was a problem hiding this comment.
This makes me wonder if a macro that corresponds to "the latest numpy C API version" would be useful. If it doesn't exist already.
Member
|
Doesn't need a backport? |
Member
|
Forgot to tag it, I don't think this one is problematic to backport. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be honest, I think we should just delete this from the public API. But I thought I'll start with this, since at least in principle that isn't a bug-release thing to backport.
(And I won't have squirms to delete this even in the future.)
I am not sure setting warnings to errors is wise (at least for Cython and MSVC). OTOH, the Cython module currently truly does nothing except include the headers (it doesn't even use the NumPy
.pydyet).Closes gh-26756