BUG: fix f2py tests to work with v2 API#26971
Merged
Merged
Conversation
This is a clear bug which CI unfortunately doesn't see because it just skips the f2py test if compilation fails (which it does here). The error is slightly more precise now, but not precise enough to avoid that issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #26935.
Fixes #26917. I've also modernised/improved the code in the relevant test files.
CI was failing prior to a4bd4a8 due to compiler errors in CI. Obviously not ideal reinstating this, but locally on my
macOS 14.5 arm64all tests pass withspin test -m full.This is a clear bug which CI unfortunately doesn't see because it just skips the f2py test if compilation fails (which it does here).
The error is slightly more precise now, but not precise enough to avoid that issue.