Skip to content

WIP: top_k draft implementation #26666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JuliaPoo wants to merge 15 commits into from
Closed

WIP: top_k draft implementation #26666

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
5984fe6
WIP: top_k draft implementation
JuliaPoo Jun 12, 2024
d724d21
Fix lint errors
JuliaPoo Jun 12, 2024
e8f7403
Fix lint errors
JuliaPoo Jun 12, 2024
11e11d1
DOC: Added notes to np.top_k
JuliaPoo Jun 14, 2024
6620311
DOC: Modified notes to np.top_k
JuliaPoo Jun 14, 2024
7322015
DOC: Modified notes to np.top_k
JuliaPoo Jun 14, 2024
7008981
DOC: add notes about sort order of nan to top_k
JuliaPoo Jul 2, 2024
c15dfbf
Merge branch 'main' into issue-15128-topk-feat
JuliaPoo Jul 2, 2024
5b6e153
Update submodules from merge
JuliaPoo Jul 2, 2024
d2f3d39
DOC: Add release note for top_k
JuliaPoo Jul 2, 2024
85147d6
DOC: Add release note for top_k
JuliaPoo Jul 2, 2024
a4e501f
Merge branch 'issue-15128-topk-feat' of https://github.com/JuliaPoo/n…
JuliaPoo Jul 2, 2024
fed3e6a
DOC: update top_k docs to pass doctest
JuliaPoo Jul 2, 2024
8d52223
Update submodules
JuliaPoo Jul 2, 2024
54fbc56
np.top_k push nans to the back for floating and complex
JuliaPoo Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
DOC: update top_k docs to pass doctest
  • Loading branch information
@JuliaPoo
JuliaPoo committed Jul 2, 2024
commit fed3e6a9944c7778af8e65847ebb15d774456cdf
2 changes: 1 addition & 1 deletion numpy/_core/fromnumeric.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ def top_k(a, k, /, *, axis=-1, largest=True):
>>> a.flatten()
array([1, 2, 3, 4, 5, 5, 4, 3, 2, 1, 3, 4, 5, 1, 2])
>>> np.top_k(a, 2, axis=None)
(array([5, 5]), array([ 5, 12]))
(array([5, 5]), array([ 4, 12]))
"""
if k <= 0:
raise ValueError(f'k(={k}) provided must be positive.')
Expand Down