Skip to content

BUG: Use Python pickle protocol version 4 for np.save #26388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattip merged 4 commits into from
May 16, 2024
Merged

BUG: Use Python pickle protocol version 4 for np.save #26388

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
413b53b
BUG: Use default Python pickle protocol version rather than outdated …
vxst May 6, 2024
97131c1
Update default pickle of np.save to 4
vxst May 10, 2024
d58f953
Merge branch 'numpy:main' into B_26224
vxst May 14, 2024
039538a
Adds document for default pickle protocol 4
vxst May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Adds document for default pickle protocol 4
  • Loading branch information
@vxst
vxst committed May 16, 2024
commit 039538a842147262f69eb3d29366ba5b3c6e02ec
3 changes: 3 additions & 0 deletions doc/release/upcoming_changes/26388.performance.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
* `numpy.save` now uses pickle protocol version 4 for saving arrays with
object dtype, which allows for pickle objects larger than 4GB and improves
saving speed by about 5% for large arrays.
2 changes: 1 addition & 1 deletion numpy/lib/_npyio_impl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,7 +520,7 @@ def save(file, arr, allow_pickle=True, fix_imports=True):
arbitrary code) and portability (pickled objects may not be loadable
on different Python installations, for example if the stored objects
require libraries that are not available, and not all pickled data is
compatible between Python 2 and Python 3).
compatible between different versions of Python).
Default: True
fix_imports : bool, optional
Only useful in forcing objects in object arrays on Python 3 to be
Expand Down