ENH: Bump Highway to HEAD and remove platform filter#26273
Conversation
seiko2plus
left a comment
seiko2plus
left a comment
There was a problem hiding this comment.
LGTM, but I think it's better to test it against the CI/wheel build before it gets merged. I added the wheel build label, but it seems close/reopening the pr is required.
|
close/reopen let's see! |
|
The failures seem unrelated. The macOS x86-64 wheel builds are failing on |
|
The macos wheel failures are unrelated, for instance the scheduled build from a few days ago is also failing. I will investigate. |
|
Thanks @mattip. Let's hold off on merging for a bit here. While the failures are unrelated, they prevent running the macOS arm64 tests that we wanted to double check with this Highway change. |
This results in a pretty nice boost on the effected platforms 😸
|
@Mousius to retest, the new commit should again have |
I felt so happy that I got this running before I left this morning 😸 I've updated it.. |
* BLD: Fix x86-simd-sort build failure on openBSD * MAINT: Update highway to 1dbb1180. * MAINT: Update various sort files from main - Update highway-qsort.dispatch.cpp. - Update x86_simd_argsort.dispatch.cpp - Update x86_simd_qsort.dispatch.cpp - Update x86_simd_qsort_16bit.dispatch.cpp * MAINT: Update vendored-meson from main * MAINT: Update "numpy/_core/meson.build" from #26273 --------- Co-authored-by: Raghuveer Devulapalli <raghuveer.devulapalli@intel.com>
4 participants
This results in a pretty nice boost on the effected platforms 😸
[wheel build]