Skip to content

API,MAINT: Reorganize array-wrap calling and introduce return_scalar #25409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seberg merged 18 commits into from
Jan 20, 2024
Merged

API,MAINT: Reorganize array-wrap calling and introduce return_scalar #25409

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
0ba20d7
API: Reorganize `__array_wrap__` and add `return_scalar=False`
seberg Nov 10, 2023
e6fdbdc
BUG: Fix niche bug in rounding.
seberg Dec 17, 2023
b9fb29e
MAINT: Adjust __array_wrap__ in code and tests (also deprecation test)
seberg Dec 17, 2023
3c51b0f
MAINT: Use/move the simplest C-wrapping also
seberg Dec 17, 2023
ad0e168
DOC: Update doc and add release note
seberg Dec 17, 2023
09ba729
STY: Make linter happy in old tests
seberg Dec 17, 2023
2ef4302
MAINT: Silence GCC warning (value cannot really be used uninitialized)
seberg Dec 17, 2023
411e2db
MAINT: Small style fixes
seberg Dec 18, 2023
4846b1d
BUG: Fix reference leak in ufunc array-wrapping
seberg Dec 18, 2023
a2cee02
BUG: Fix leak for result arrays in all ufunc calls
seberg Dec 19, 2023
3caf819
Ensure we try passing context and address related smaller review comm…
seberg Jan 17, 2024
5d2c04c
Merge branch 'main' into clean-wrapping
seberg Jan 17, 2024
181a376
Ensure we don't try `context=None` and expand code comment
seberg Jan 17, 2024
8621eee
Rely on return_scalar always being right (and style nit)
seberg Jan 17, 2024
3122538
Remove outdated comments as per review
seberg Jan 17, 2024
497c535
Let's just undo force-wrap for now for reductions (its a change...)
seberg Jan 17, 2024
f50ff16
ENH: Chain the original error when the deprecationwarning is raised
seberg Jan 19, 2024
606f5c3
BUG,MAINT: Address Martens review comments
seberg Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
MAINT: Silence GCC warning (value cannot really be used uninitialized)
  • Loading branch information
@seberg
seberg committed Dec 17, 2023
commit 2ef43027c98a71833d9946e7cd2beeee1259c6c5
2 changes: 1 addition & 1 deletion numpy/_core/src/multiarray/arraywrap.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ npy_find_array_wrap(
PyObject *wrap = NULL;
PyObject *wrap_type = NULL;

double priority;
double priority = 0; /* silence uninitialized warning */

for (int i = 0; i < nin; i++) {
PyObject *obj = inputs[i];
Expand Down