Skip to content

DOC: Add missing changelogs for NEP 52 PRs#24510

Merged
charris merged 3 commits into
numpy:mainfrom
mtsokol:generate-existing-2-0-0-release-notes
Aug 23, 2023
Merged

DOC: Add missing changelogs for NEP 52 PRs#24510
charris merged 3 commits into
numpy:mainfrom
mtsokol:generate-existing-2-0-0-release-notes

Conversation

@mtsokol
Copy link
Copy Markdown
Member

@mtsokol mtsokol commented Aug 23, 2023

Hi @rgommers,

This PR contains two commits: One with release notes that I obtained by running:

towncrier build --version "2.0.0"

And second one with manually added release notes for four merged Python API cleanup PRs: #23830, #24154, #24316, #24357.

Comment thread doc/source/release/2.0.0-notes.rst Outdated
Comment thread doc/source/release/2.0.0-notes.rst Outdated
@@ -1,45 +1,313 @@
.. currentmodule:: numpy
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep this.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restored!



New functions
=============
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should be the desired indentation here?
I see that e.g. 1.23.0-notes.rst also has New functions written this way.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happens, the notes get copied one to another :) Probably doesn't matter, but headings flush on left works.

@charris
Copy link
Copy Markdown
Member

charris commented Aug 23, 2023

Couple of nits. If you hit the ... to the upper right of the file entry and click view, you can see the rendered doc.

@charris charris merged commit 09925cf into numpy:main Aug 23, 2023
@charris
Copy link
Copy Markdown
Member

charris commented Aug 23, 2023

Thanks @mtsokol.

@mtsokol mtsokol deleted the generate-existing-2-0-0-release-notes branch April 3, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants