Skip to content

BUG: don't mutate list of fake libraries while iterating over it #18295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charris merged 5 commits into from
Feb 4, 2021
Merged

BUG: don't mutate list of fake libraries while iterating over it #18295

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f2e8acc
BUG: don't mutate list of fake libraries while iterating over it
mckib2 Feb 2, 2021
9a23e7a
BUG: iterate over copy of list
mckib2 Feb 2, 2021
13603d4
TST: add build test for build_ext fix (#1)
mckib2 Feb 3, 2021
07730c1
FIX: check for f77 compiler before test is run
mckib2 Feb 4, 2021
8201407
DOC: add comment explaining that a list copy is necessary
mckib2 Feb 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
FIX: check for f77 compiler before test is run
  • Loading branch information
@mckib2
mckib2 committed Feb 4, 2021
commit 07730c1be779919aafbb16d7f3b737cc56c76848
9 changes: 8 additions & 1 deletion numpy/distutils/tests/test_build_ext.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
'''Tests for numpy.distutils.build_ext.'''

import os
import shutil
import subprocess
import sys
from textwrap import indent, dedent
Expand All @@ -13,6 +12,14 @@ def test_multi_fortran_libs_link(tmp_path):
Ensures multiple "fake" static libraries are correctly linked.
see gh-18295
'''

# We need to make sure we actually have an f77 compiler.
# This is nontrivial, so we'll borrow the utilities
# from f2py tests:
from numpy.f2py.tests.util import has_f77_compiler
if not has_f77_compiler():
pytest.skip('No F77 compiler found')

# make some dummy sources
with open(tmp_path / '_dummy1.f', 'w') as fid:
fid.write(indent(dedent('''\
Expand Down