Skip to content

DEP: Deprecated ndindex.ndincr#17233

Merged
seberg merged 1 commit into
numpy:masterfrom
eric-wieser:deprecate-ndincr
Sep 3, 2020
Merged

DEP: Deprecated ndindex.ndincr#17233
seberg merged 1 commit into
numpy:masterfrom
eric-wieser:deprecate-ndincr

Conversation

@eric-wieser
Copy link
Copy Markdown
Member

@eric-wieser eric-wieser commented Sep 3, 2020

The "do not use" comment has been here since bb0e4f3. (#393)

The "do not use" comment has been here since bb0e4f3.
@seberg
Copy link
Copy Markdown
Member

seberg commented Sep 3, 2020

Deprecating ndindex.ndinc() to ask users to use next(ndindex) seems clearly fine to me, its just obscure and easy to fix. Thanks Eric!

@seberg seberg merged commit 925f838 into numpy:master Sep 3, 2020
@seberg
Copy link
Copy Markdown
Member

seberg commented Sep 3, 2020

Hmm, maybe a bit quick, but it seemed super trivial, I am happy to add a deprecation test case if anyone feels its better.

EDIT: And yes, I saw that I merged it in the future ;) (the date is off by 6 days)

@seberg seberg added the 62 - Python API Changes or additions to the Python API. Mailing list should usually be notified. label Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

07 - Deprecation 62 - Python API Changes or additions to the Python API. Mailing list should usually be notified.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants