DEP: Deprecate numpy.dual.#16156
Conversation
Add a deprecation warning in the `numpy.dual` module, and remove the use of `numpy.dual` from the few places where it is used in the numpy code.
WarrenWeckesser
force-pushed
the
deprecate-dual
branch
from
598a167 to
e95fcba
Compare
|
Mailing list discussion from January: https://mail.python.org/pipermail/numpy-discussion/2020-January/080308.html |
rossbar
left a comment
rossbar
left a comment
There was a problem hiding this comment.
Would it be appropriate to add a .. deprecated:: 1.19 tag (assuming this makes it to 1.19) to the module docstring (in numpy/dual.py) or is that typically only used inside function docstrings? It does look like the numpy/dual.py module docstring gets picked up via an .. automodule and built into the reference so maybe that would be useful? I'm not sure so I thought I'd ask!
|
Please not yet for 1.19.0 - that will start emitting deprecation warnings for the latest releases of Scipy too soon. |
|
@rgommers, agreed, this can wait until after 1.19.0 is released. Can someone with the correct permissions add a 1.20.0 milestone to github? |
you now have triage permissions |
…tring. Also make the correction "Scipy" -> "SciPy" in a few places.
|
Now that master is on 1.20, lets put this in, thanks Warren! |
numpy dual is deprecated import from numpy linalg instead, details see: numpy/numpy#16156
5 participants
Add a deprecation warning in the
numpy.dualmodule, andremove the use of
numpy.dualfrom the few places where itis used in the numpy code.