Skip to content

ENH: Implement concatenate dtype and casting keyword arguments #16134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattip merged 5 commits into from
Sep 3, 2020
Merged

ENH: Implement concatenate dtype and casting keyword arguments #16134

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cfd553d
ENH: Implement concatenate dtype and casting keyword arguments
seberg May 1, 2020
3cddaa9
Apply suggestions from code review
seberg May 20, 2020
3c746b0
Fixup: Mention that it will be a TypeError (Anirudh's review)
seberg May 20, 2020
1a79c06
Update doc/release/upcoming_changes/16134.compatibility.rst
seberg Sep 3, 2020
c8eb9d4
DOC: Fixup deprecation dates
seberg Sep 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixup: Mention that it will be a TypeError (Anirudh's review)
  • Loading branch information
@seberg
seberg committed Sep 3, 2020
commit 3c746b0f60471e20627588c752dd68ad962fb33d
5 changes: 3 additions & 2 deletions numpy/core/src/multiarray/multiarraymodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -623,9 +623,10 @@ PyArray_ConcatenateFlattenedArrays(int narrays, PyArrayObject **arrays,
if (casting_not_passed && out_passed) {
/* NumPy 1.19, 2020-04-30 */
Comment thread
seberg marked this conversation as resolved.
Outdated
if (give_deprecation_warning && DEPRECATE(
"concatenate with `axis=None` will use same-kind "
"concatenate() with `axis=None` will use same-kind "
"casting by default in the future. Please use "
Comment thread
seberg marked this conversation as resolved.
Outdated
"`casting='unsafe'` to retain the old behaviour.") < 0) {
"`casting='unsafe'` to retain the old behaviour. "
"In the future this will be a TypeError.") < 0) {
Py_DECREF(sliding_view);
Py_DECREF(ret);
return NULL;
Expand Down