ENH: Implement concatenate dtype and casting keyword arguments#16134
Merged
Conversation
seberg
added
01 - Enhancement
component: numpy._core
07 - Deprecation
56 - Needs Release Note.
seberg
changed the title
seberg
force-pushed
the
concatenate-dtype
branch
2 times, most recently
from
369cac8 to
ab101e8
Compare
anirudh2290
reviewed
May 6, 2020
seberg
removed
the
56 - Needs Release Note.
seberg
force-pushed
the
concatenate-dtype
branch
2 times, most recently
from
596f057 to
f8755f9
Compare
Member
Author
|
OK, last commit should have fixed the test failure (potential use-after free of |
seberg
added
the
62 - Python API
anirudh2290
reviewed
May 20, 2020
eric-wieser
reviewed
May 20, 2020
eric-wieser
reviewed
May 20, 2020
eric-wieser
reviewed
May 20, 2020
eric-wieser
reviewed
May 20, 2020
eric-wieser
reviewed
May 20, 2020
anirudh2290
approved these changes
Jun 10, 2020
Member
|
@seberg there is a merge conflict |
seberg
force-pushed
the
concatenate-dtype
branch
2 times, most recently
from
f6b6d34 to
266b4af
Compare
Member
Author
|
Hmmm, not sure why the code-cov is so bad, I am not quite certain whether or not it considers the Deprecation warning tested, but I guess the problem is just the C-API code... I found another small bug thinking about adding a few more tests for untested Errors :)... |
Member
yep looks bad. I guess its able to correctly flag the coverage thing, but not able to point exactly what the issue is. |
Unfortunately, the casting was not consistent and sometimes used force casting (axis=None) while normally same kind casting was used. This thus deprecates the `force_casting` corner case, so that casting has to be provided in the future.
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
seberg
force-pushed
the
concatenate-dtype
branch
from
266b4af to
3c746b0
Compare
Member
|
s390x is failing typing tests, with |
mattip
reviewed
Sep 3, 2020
mattip
reviewed
Sep 3, 2020
Co-authored-by: Matti Picus <matti.picus@gmail.com>
Member
|
Thanks @seberg |
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, the casting was not consistent and sometimes used
force casting (axis=None) while normally same kind casting was used.
This thus deprecates the
force_castingcorner case, so thatcasting has to be provided in the future.
Builds on top of gh-16133 (so marking it draft) and is partially motivated as by making gh-15925 an easier transition.
The deprecation should be pretty rare, since it is in the
axis=Nonecorner-case only.