TST: Run test_large_zip in a child process#15893
Conversation
Remove gc import
|
Could you temporarily remove the |
|
Looks like there is some download step on windows failing. Is there a way to retrigger the CI manually or do I need to push an empty commit ? |
The goal of 2da3d4f was to check that PyPy passes the new format of the test, which it does. So if you can revert that commit I think this is ready. It would be nice to add a comment to the effect of "run in a subprocess to ensure memory is released on PyPy" Looking at the log for PyPy, there are some tests that could be marked |
This reverts commit 2da3d4f.
Good point! I can take a look at this and open another PR. I am wondering if we need to change the required memory to probably 8 or 9 GB for this particular test, maybe we can monitor this for a few CI runs and change if required. |
|
Thanks @anirudh2290 |
Since numpy#15893, test_large_zip's actual test is run in a child process, so when this test raises a MemoryError exception, the exception is lost and the @requires_memory decorator can't catch it to return an xfail. This commit uses a boolean variable in shared memory to flag if the exception was raised, and in that case, re-raise it in the parent process. Fixes numpy#16889
…h-16890) Since #15893, test_large_zip's actual test is run in a child process, so when this test raises a MemoryError exception, the exception is lost and the @requires_memory decorator can't catch it to return an xfail. This commit uses a boolean variable in shared memory to flag if the exception was raised, and in that case, re-raise it in the parent process. Fixes #16889
…umpygh-16890) Since numpy#15893, test_large_zip's actual test is run in a child process, so when this test raises a MemoryError exception, the exception is lost and the @requires_memory decorator can't catch it to return an xfail. This commit uses a boolean variable in shared memory to flag if the exception was raised, and in that case, re-raise it in the parent process. Fixes numpy#16889
2 participants
@mattip