Skip to content

MAINT: Added Python3.8 branch to dll lib discovery#14993

Merged
charris merged 1 commit into
numpy:maintenance/1.17.xfrom
charris:backport-14974
Nov 27, 2019
Merged

MAINT: Added Python3.8 branch to dll lib discovery#14993
charris merged 1 commit into
numpy:maintenance/1.17.xfrom
charris:backport-14974

Conversation

@charris
Copy link
Copy Markdown
Member

@charris charris commented Nov 27, 2019

Backport of #14974.

Closes #14923

Not sure if I've did the right fix regarding the issue linked above, however it does indeed fix the NumPy/SciPy related dll import errors on Windows/Python3.8.

@pv
Copy link
Copy Markdown
Member

pv commented Nov 27, 2019

It's not a blocker for Scipy wheels (we have workaround in _distributor_init.py). However, it's an inconvenience for people building on Windows on Python 3.8 themselves, so backporting might make sense (AFAIK, it shouldn't have ill effects).

@ilayn
Copy link
Copy Markdown
Contributor

ilayn commented Nov 27, 2019

I am not sure what blocking means but if I install the wheels for 3.8 importing scipy fails. So it is in that sense blocking for at least for 1.3.2. The _distributor_init.py didn't fix things for me and I had to resort back to dll discovery hence the PR.

@charris charris merged commit 56f5a9a into numpy:maintenance/1.17.x Nov 27, 2019
@charris charris deleted the backport-14974 branch November 27, 2019 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants