Skip to content

Fix move/copy to root folder#6218

Merged
AndyScherzinger merged 1 commit into
masterfrom
moveFails
Jun 5, 2020
Merged

Fix move/copy to root folder#6218
AndyScherzinger merged 1 commit into
masterfrom
moveFails

Conversation

@tobiasKaminsky
Copy link
Copy Markdown
Member

@tobiasKaminsky tobiasKaminsky commented Jun 4, 2020

Fix #6137
Signed-off-by: tobiasKaminsky tobias@kaminsky.me

Testing

Writing tests is very important. Please try to write some tests for your PR.
If you need help, please do not hesitate to ask in this PR for help.

unit tests
instrumented tests
UI tests

  • Tests written, or not not needed

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot
Copy link
Copy Markdown
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14354.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Copy Markdown
Collaborator

master-IT test failed, but no output was generated. Maybe a preliminary stage failed.

@nextcloud-android-bot
Copy link
Copy Markdown
Collaborator

@nextcloud-android-bot
Copy link
Copy Markdown
Collaborator

Codacy

390

Lint

TypemasterPR
Warnings9595
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings27
Correctness Warnings64
Internationalization Warnings9
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings75
Security Warnings44
Dodgy code Warnings139
Total371

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings27
Correctness Warnings64
Internationalization Warnings9
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings75
Security Warnings44
Dodgy code Warnings139
Total371

@AndyScherzinger AndyScherzinger merged commit cad9e59 into master Jun 5, 2020
@delete-merged-branch delete-merged-branch Bot deleted the moveFails branch June 5, 2020 06:59
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.13.0 milestone Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Copy/move to root folder fails

3 participants