Skip to content

Updating gradle-plugin to 3.0.0-beta7 + forced move buildToolsVersion 26.0.2#1627

Merged
tobiasKaminsky merged 2 commits into
masterfrom
AS300beta7
Oct 9, 2017
Merged

Updating gradle-plugin to 3.0.0-beta7 + forced move buildToolsVersion 26.0.2#1627
tobiasKaminsky merged 2 commits into
masterfrom
AS300beta7

Conversation

@AndyScherzinger

@AndyScherzinger AndyScherzinger commented Oct 4, 2017

Copy link
Copy Markdown
Member
  • gradle-plugin 3.0.0-beta7
  • buildToolsVersion 26.0.2 (enforced by 3.0.0-beta7)

Hope this'll also work for f-droid with the next release/RC, so putting @Bubu on cc as well as @tobiasKaminsky and @mario

@Bubu

Bubu commented Oct 4, 2017

Copy link
Copy Markdown
Contributor

@AndyScherzinger I don't think build tools 26.0.2 is on the fdroid build server yet.

Does this fix a problem so it has to be included for 2.0 or can this wait for later?

@AndyScherzinger

Copy link
Copy Markdown
Member Author

@Bubu tricky to answer... This is a build issue. Google uses time bombs, so as soon as beta6 turns 4 weeks old it'll enforce an update to beta7 except you setting a special environment variable with a daily changing value to not break the build. Now, when you upgrade to beta7 the plug in enforces the build tools update in the same way beta6 enforces beta7.

So for now it works but just for a couple more days :/

@Bubu

Bubu commented Oct 4, 2017

Copy link
Copy Markdown
Contributor

@AndyScherzinger I see, then you need to upgrade.
But preferably you'd need to wait for a version that doesn't break after 4 weeks for the final 2.0 release?

@Bubu

Bubu commented Oct 4, 2017

Copy link
Copy Markdown
Contributor

@AndyScherzinger I just did a test build and apparently gradle now automatically installs missing build tools versions. So this should hopefully be no problem at all for f-droid... 🤞

@AndyScherzinger

Copy link
Copy Markdown
Member Author

@Bubu that depends. Unfortunately Google doesn't provide any information on when they will ship a final version of the plugin :/
The build tools is a final version though.

@AndyScherzinger

Copy link
Copy Markdown
Member Author

Fingers crossed, that sounds awesome so we might merge it and give it a try?

@mario

mario commented Oct 4, 2017

Copy link
Copy Markdown
Contributor

👍

Approved with PullApprove

@AndyScherzinger

Copy link
Copy Markdown
Member Author

@Bubu I merged it to dev so the next Nextcloud dev build tagged for f-droid will contain this chance. Hope f-droid picks that build up very soon so we see if it works 😃

@AndyScherzinger AndyScherzinger mentioned this pull request Oct 5, 2017
@AndyScherzinger AndyScherzinger force-pushed the AS300beta7 branch 2 times, most recently from 04d7cd8 to 68ab6d0 Compare October 6, 2017 07:31
@AndyScherzinger

Copy link
Copy Markdown
Member Author

@tobiasKaminsky rebased to latest master, in case you want/can do a RC9 release today

@tobiasKaminsky

tobiasKaminsky commented Oct 9, 2017

Copy link
Copy Markdown
Member

👍
I'll rebase and merge it afterwards now.

Approved with PullApprove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants