ncmpcpp · kamack38 · Feb 12, 2025 · Feb 12, 2025
diff --git a/doc/config b/doc/config
@@ -563,6 +563,10 @@
 ##
 #use_console_editor = yes
 #
+## Note: This requires use_console_editor to be set to yes
+##
+#sync_lyrics_to_tags = no
+#
 ##### colors definitions #####
 ##
 ## It is possible to set a background color by setting a color value

diff --git a/doc/ncmpcpp.1 b/doc/ncmpcpp.1
@@ -414,6 +414,9 @@ Path to external editor used to edit lyrics.
 .B use_console_editor = yes/no
 If your external editor is console application, you need to enable it.
 .TP
+.B sync_lyrics_to_tags = yes/no
+Automatically writes saved lyrics using tags to the song file
+.TP
 .B colors_enabled = yes/no
 No need to describe it, huh?
 .TP

diff --git a/src/lyrics_fetcher.cpp b/src/lyrics_fetcher.cpp
@@ -250,7 +250,7 @@ LyricsFetcher::Result TagsLyricsFetcher::fetch([[maybe_unused]] const std::strin
 
 	TagLib::PropertyMap properties = f.file()->properties();
 
-	if (properties.contains("LYRICS"))
+    if (properties.contains("LYRICS"))
 	{
 		result.first = true;
 		result.second = properties["LYRICS"].toString("\n\n").to8Bit(true);

diff --git a/src/screens/lyrics.cpp b/src/screens/lyrics.cpp
@@ -27,6 +27,17 @@
 #include <fstream>
 #include <thread>
 
+#include "tags.h"
+#ifdef HAVE_TAGLIB_H
+// #include <fileref.h>
+// #include <tag.h>
+#include <taglib/fileref.h>
+#include <taglib/tag.h>
+#include <taglib/mpegfile.h>
+#include <taglib/id3v2tag.h>
+#include <taglib/unsynchronizedlyricsframe.h>
+#endif // HAVE_TAGLIB_H
+
 #include "curses/scrollpad.h"
 #include "screens/browser.h"
 #include "charset.h"
@@ -329,6 +340,41 @@ void Lyrics::edit()
 	if (Config.use_console_editor)
 	{
 		runExternalConsoleCommand(Config.external_editor + " '" + filename + "'");
+#ifdef HAVE_TAGLIB_H
+		if (Config.sync_lyrics_to_tags) {
+			std::string song_file;
+			if (m_song.isFromDatabase())
+				song_file += Config.mpd_music_dir;
+			song_file += m_song.getURI();
+
+			TagLib::MPEG::File file(song_file.c_str());
+			std::fstream lyrics_file(filename); 
+			std::ostringstream ss;
+			ss << lyrics_file.rdbuf();
+
+			TagLib::ID3v2::Tag *id3v2Tag = file.ID3v2Tag(true);
+			if (!id3v2Tag) {
+				std::cerr << "Error: No ID3v2 tag found." << std::endl;
+				return;
+			}
+
+			TagLib::ID3v2::FrameList frames = id3v2Tag->frameList("USLT");
+			for (auto &frame : frames) {
+				id3v2Tag->removeFrame(frame, true);
+			}
+
+			TagLib::ID3v2::UnsynchronizedLyricsFrame *lyricsFrame = new TagLib::ID3v2::UnsynchronizedLyricsFrame();
+			lyricsFrame->setText(TagLib::String(ss.str(), TagLib::String::UTF8));
+
+			id3v2Tag->addFrame(lyricsFrame);
+
+			if (file.save()) {
+				std::cout << "Lyrics written successfully!" << std::endl;
+			} else {
+				std::cerr << "Error: Failed to save lyrics." << std::endl;
+			}
+		}
+#endif // HAVE_TAGLIB_H
 		fetch(m_song);
 	}
 	else

diff --git a/src/settings.cpp b/src/settings.cpp
@@ -594,6 +594,7 @@ bool Configuration::read(const std::vector<std::string> &config_paths, bool igno
 		      return --mode;
 	      });
 	p.add("external_editor", &external_editor, "nano", adjust_path);
+    p.add("sync_lyrics_to_tags", &sync_lyrics_to_tags, "no", yes_no);
 	p.add("use_console_editor", &use_console_editor, "yes", yes_no);
 	p.add("colors_enabled", &colors_enabled, "yes", yes_no);
 	p.add("empty_tag_color", &empty_tags_color, "cyan");

diff --git a/src/settings.h b/src/settings.h
@@ -77,6 +77,7 @@ struct Configuration
 	Format::AST<wchar_t> new_header_second_line;
 
 	std::string external_editor;
+	bool sync_lyrics_to_tags;
 	std::string system_encoding;
 	std::string execute_on_song_change;
 	std::string execute_on_player_state_change;