Replace non-standard VLAs with std::vector in Visualizer stereo mode (#654)

hyder365 · web-flow · commit 04f2f439cae8 · 2026-06-26T00:43:48.000+02:00
Co-authored-by: Devon Kirk &lt;hyder365@users.noreply.github.com&gt;
diff --git a/src/screens/visualizer.cpp b/src/screens/visualizer.cpp
@@ -33,6 +33,7 @@
 #include <fcntl.h>
 #include <netdb.h>
 #include <cassert>
+#include <vector>
 
 #include "global.h"
 #include "settings.h"
@@ -219,15 +220,15 @@ void Visualizer::update()
 	if (Config.visualizer_in_stereo)
 	{
 		auto chan_samples = m_rendered_samples.size()/2;
-		int16_t buf_left[chan_samples], buf_right[chan_samples];
+		std::vector<int16_t> buf_left(chan_samples), buf_right(chan_samples);
 		for (size_t i = 0, j = 0; i < m_rendered_samples.size(); i += 2, ++j)
 		{
 			buf_left[j] = m_rendered_samples[i];
 			buf_right[j] = m_rendered_samples[i+1];
 		}
 		size_t half_height = w.getHeight()/2;
 
-		(this->*drawStereo)(buf_left, buf_right, chan_samples, half_height);
+		(this->*drawStereo)(buf_left.data(), buf_right.data(), chan_samples, half_height);
 	}
 	else
 	{

Original file line number	Diff line number	Diff line change
`@@ -33,6 +33,7 @@`
`33`	`33`	`#include <fcntl.h>`
`34`	`34`	`#include <netdb.h>`
`35`	`35`	`#include <cassert>`
	`36`	`+#include <vector>`
`36`	`37`
`37`	`38`	`#include "global.h"`
`38`	`39`	`#include "settings.h"`
`@@ -219,15 +220,15 @@ void Visualizer::update()`
`219`	`220`	`if (Config.visualizer_in_stereo)`
`220`	`221`	`{`
`221`	`222`	`auto chan_samples = m_rendered_samples.size()/2;`
`222`		`- int16_t buf_left[chan_samples], buf_right[chan_samples];`
	`223`	`+ std::vector<int16_t> buf_left(chan_samples), buf_right(chan_samples);`
`223`	`224`	`for (size_t i = 0, j = 0; i < m_rendered_samples.size(); i += 2, ++j)`
`224`	`225`	`{`
`225`	`226`	`buf_left[j] = m_rendered_samples[i];`
`226`	`227`	`buf_right[j] = m_rendered_samples[i+1];`
`227`	`228`	`}`
`228`	`229`	`size_t half_height = w.getHeight()/2;`
`229`	`230`
`230`		`- (this->*drawStereo)(buf_left, buf_right, chan_samples, half_height);`
	`231`	`+ (this->*drawStereo)(buf_left.data(), buf_right.data(), chan_samples, half_height);`
`231`	`232`	`}`
`232`	`233`	`else`
`233`	`234`	`{`