Fix bug: 1. patch_context cannot revert classmethod 2. kernels testcase miss trust_remote_code and revision#1729
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for a new repository type, REPO_TYPE_KERNEL, across the download utilities and constants, and refactors the unpatching logic in patcher.py to correctly restore patched methods as classmethods. The review feedback highlights critical missing updates for REPO_TYPE_KERNEL in file_download.py and snapshot_download.py that could cause runtime failures during kernel downloads. Additionally, it recommends updating an outdated error message and replacing a bare except: clause with a specific AttributeError exception handler in patcher.py.
wangxingjun778
approved these changes
May 31, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.