Skip to content

fix plugin#1712

Merged
tastelikefeet merged 3 commits into
masterfrom
fix/0512-1
May 12, 2026
Merged

fix plugin#1712
tastelikefeet merged 3 commits into
masterfrom
fix/0512-1

Conversation

@tastelikefeet
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a plugin whitelisting mechanism to allow specific plugins, such as pai-easycv, to bypass the trust_remote_code security check. A new utility function filter_plugin_not_in_whitelist is implemented and integrated into the pipeline and trainer builders. However, a critical logic error was identified in both builders: overwriting the plugins variable with the filtered list removes whitelisted plugins before they can be registered and loaded. It is recommended to use a separate variable for the security validation to ensure whitelisted plugins are still processed.

Comment thread modelscope/pipelines/builder.py Outdated
Comment thread modelscope/trainers/builder.py Outdated
Comment thread modelscope/utils/plugins.py Outdated
@tastelikefeet tastelikefeet merged commit b7d4774 into master May 12, 2026
2 of 3 checks passed
@tastelikefeet tastelikefeet deleted the fix/0512-1 branch May 12, 2026 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants