rewrite recursive conditional types to be tail-recursive#256
Draft
DetachHead wants to merge 9 commits into
Draft
rewrite recursive conditional types to be tail-recursive#256DetachHead wants to merge 9 commits into
DetachHead wants to merge 9 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎁 Pull Request
testsfolder)npm test(there were tests failing before i made my changes, i don't think i introduced any new failures)Fixes
closes #255
Why have you made changes?
in typescript 4.5, tail-recursive conditional types are now optimized such that the recursion limit can be much higher (1000) instead of 100. see the blog post and microsoft/TypeScript#45711
What changes have you made?
IterationMap./scripts/tools/update-IterationMap.tsrewrote types to be tail-recursive
String/JoinList/FlattenList/TakeAny/ComputeCommunity/IncludesDeepFunction/AutoPathWhat tests have you updated?
tests/String.tsIs there any breaking changes?
Anything else worth mentioning?