Only resolve the code lens when then opened file is on test source path#997
Merged
Conversation
Eskibear
previously approved these changes
May 18, 2020
testforstephen
previously approved these changes
May 19, 2020
| private registerListenersDebounce: (() => Promise<void>) & _.Cancelable = _.debounce(this.registerListenersInternal, 2 * 1000 /*ms*/); | ||
|
|
||
| public async registerListeners(): Promise<void> { | ||
| public async registerListeners(debounce: boolean = true): Promise<void> { |
Contributor
There was a problem hiding this comment.
how about change the default to false? so if you want to register directly, then just call registerListeners(), that looks more natural to me.
| } | ||
|
|
||
| public async provideCodeLenses(document: TextDocument, _token: CancellationToken): Promise<CodeLens[]> { | ||
| if (!testFileWatcher.isOnTestSourcePath(document.uri.fsPath)) { |
Contributor
There was a problem hiding this comment.
About filter the codelens, it seems vscode supports glob pattern on whether to trigger codelens.
export interface DocumentFilter {
/**
* A language id, like `typescript`.
*/
language?: string;
/**
* A Uri [scheme](#Uri.scheme), like `file` or `untitled`.
*/
scheme?: string;
/**
* A [glob pattern](#GlobPattern) that is matched on the absolute path of the document. Use a [relative pattern](#RelativePattern)
* to filter documents to a [workspace folder](#WorkspaceFolder).
*/
pattern?: GlobPattern;
}
testforstephen
previously approved these changes
May 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.