Additional changes to handle constructor scenario

microsoft · sarangan12 · Jun 24, 2016 · May 24, 2016 · May 26, 2016 · May 26, 2016
commit ed5052d9aa2016698de4e923c47f0acad823c297
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -14214,9 +14214,7 @@ namespace ts {
 
         function checkUnusedLocals(node: FunctionDeclaration | MethodDeclaration | ConstructorDeclaration | FunctionExpression | ArrowFunction): void {
             checkUnusedIdentifiers(node);
-            if (node.kind !== SyntaxKind.Constructor) {
-                checkUnusedParameters(node);
-            }
+            checkUnusedParameters(node);
         }
 
         function checkUnusedIdentifiers(node: FunctionDeclaration | MethodDeclaration | ConstructorDeclaration | FunctionExpression | ArrowFunction): void {
@@ -14236,7 +14234,13 @@ namespace ts {
                 for (const key in node.locals) {
                     if (hasProperty(node.locals, key) && !node.locals[key].hasReference && node.locals[key].valueDeclaration && node.locals[key].valueDeclaration.kind) {
                         if (node.locals[key].valueDeclaration.kind === SyntaxKind.Parameter && node.parent.kind !== SyntaxKind.InterfaceDeclaration) {
-                            error(node.locals[key].valueDeclaration, Diagnostics.Parameter_0_has_never_been_used, key);
+                            if (node.locals[key].valueDeclaration.modifiers) {
+                                if (!checkModifiersForPublicAccess(node.locals[key].valueDeclaration.modifiers)) {
+                                    error(node.locals[key].valueDeclaration, Diagnostics.Parameter_0_has_never_been_used, key);
+                                }
+                            } else {
+                                error(node.locals[key].valueDeclaration, Diagnostics.Parameter_0_has_never_been_used, key);
+                            }                            
                         }
                     }
                 }
@@ -14289,6 +14293,15 @@ namespace ts {
             return false;
         }
 
+        function checkModifiersForPublicAccess(modifiers: ModifiersArray): boolean {
+            for (let i = 0; i < modifiers.length; i++) {
+                if (modifiers[i].kind === SyntaxKind.PublicKeyword) {
+                    return true;
+                }
+            }
+            return false;
+        }
+
         function checkBlock(node: Block) {
             // Grammar checking for SyntaxKind.Block
             if (node.kind === SyntaxKind.Block) {

diff --git a/tests/baselines/reference/unusedIdentifiersConsolidated1.errors.txt b/tests/baselines/reference/unusedIdentifiersConsolidated1.errors.txt
diff --git a/tests/baselines/reference/unusedIdentifiersConsolidated1.js b/tests/baselines/reference/unusedIdentifiersConsolidated1.js
diff --git a/tests/baselines/reference/unusedMultipleParameter1InContructor.errors.txt b/tests/baselines/reference/unusedMultipleParameter1InContructor.errors.txt
@@ -0,0 +1,16 @@
+tests/cases/compiler/unusedMultipleParameter1InContructor.ts(3,17): message TS6133: Parameter 'person' has never been used.
+tests/cases/compiler/unusedMultipleParameter1InContructor.ts(4,13): message TS6132: Variable 'unused' has never been used.
+
+
+==== tests/cases/compiler/unusedMultipleParameter1InContructor.ts (2 errors) ====
+
+    class Dummy {
+        constructor(person: string, person2: string) {
+                    ~~~~~~~~~~~~~~
+!!! message TS6133: Parameter 'person' has never been used.
+            var unused = 20;
+                ~~~~~~
+!!! message TS6132: Variable 'unused' has never been used.
+            person2 = "Dummy value";
+        }
+    }