Skip to content

Improved checking of for-in statements #6379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahejlsberg merged 9 commits into from
Jan 8, 2016
Merged

Improved checking of for-in statements #6379

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a05b1de
Change for-in iteration variable type from any to string
ahejlsberg Jan 6, 2016
75b4c50
Updating existing tests
ahejlsberg Jan 6, 2016
dbb4544
Adding new tests
ahejlsberg Jan 6, 2016
9ce5e64
Accepting new baselines
ahejlsberg Jan 6, 2016
120569a
Support for-in both with and without variable declaration
ahejlsberg Jan 7, 2016
1798024
Updating tests
ahejlsberg Jan 7, 2016
537fb4a
Merge branch 'master' into forInChecking
ahejlsberg Jan 7, 2016
3344a42
Check for numeric index signature instead of array-like type
ahejlsberg Jan 7, 2016
a0fcc0f
Accepting new baselines
ahejlsberg Jan 7, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Updating existing tests
  • Loading branch information
@ahejlsberg
ahejlsberg committed Jan 6, 2016
commit 75b4c50cec458a79623bbd4bea7e992e13348599
4 changes: 2 additions & 2 deletions tests/cases/compiler/capturedLetConstInLoop5.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ function foo00(x) {
var v = x;
(function() { return x + v });
(() => x + v);
if (x == 1) {
if (x == "1") {
return;
}
}
Expand Down Expand Up @@ -158,7 +158,7 @@ function foo00_c(x) {
var v = x;
(function() { return x + v });
(() => x + v);
if (x == 1) {
if (x == "1") {
return;
}
}
Expand Down
4 changes: 2 additions & 2 deletions tests/cases/compiler/capturedLetConstInLoop5_ES6.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ function foo00(x) {
var v = x;
(function() { return x + v });
(() => x + v);
if (x == 1) {
if (x == "1") {
return;
}
}
Expand Down Expand Up @@ -160,7 +160,7 @@ function foo00_c(x) {
var v = x;
(function() { return x + v });
(() => x + v);
if (x == 1) {
if (x == "1") {
return;
}
}
Expand Down
8 changes: 4 additions & 4 deletions tests/cases/compiler/capturedLetConstInLoop6.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ for (let x of []) {
for (let x in []) {
(function() { return x});
(() => x);
if (x == 1) {
if (x == "1") {
break;
}
if (x == 2) {
if (x == "2") {
continue;
}
}
Expand Down Expand Up @@ -132,10 +132,10 @@ for (const x of []) {
for (const x in []) {
(function() { return x});
(() => x);
if (x == 1) {
if (x == "1") {
break;
}
if (x == 2) {
if (x == "2") {
continue;
}
}
Expand Down
8 changes: 4 additions & 4 deletions tests/cases/compiler/capturedLetConstInLoop6_ES6.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ for (let x of []) {
for (let x in []) {
(function() { return x});
(() => x);
if (x == 1) {
if (x == "1") {
break;
}
if (x == 2) {
if (x == "2") {
continue;
}
}
Expand Down Expand Up @@ -133,10 +133,10 @@ for (const x of []) {
for (const x in []) {
(function() { return x});
(() => x);
if (x == 1) {
if (x == "1") {
break;
}
if (x == 2) {
if (x == "2") {
continue;
}
}
Expand Down
16 changes: 8 additions & 8 deletions tests/cases/compiler/capturedLetConstInLoop7.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,16 @@ l00:
for (let x in []) {
(function() { return x});
(() => x);
if (x == 1) {
if (x == "1") {
break;
}
if (x == 1) {
if (x == "1") {
break l00;
}
if (x == 2) {
if (x == "2") {
continue;
}
if (x == 2) {
if (x == "2") {
continue l00;
}
}
Expand Down Expand Up @@ -209,16 +209,16 @@ l00_c:
for (const x in []) {
(function() { return x});
(() => x);
if (x == 1) {
if (x == "1") {
break;
}
if (x == 1) {
if (x == "1") {
break l00_c;
}
if (x == 2) {
if (x == "2") {
continue;
}
if (x == 2) {
if (x == "2") {
continue l00_c;
}
}
Expand Down
16 changes: 8 additions & 8 deletions tests/cases/compiler/capturedLetConstInLoop7_ES6.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,16 @@ l00:
for (let x in []) {
(function() { return x});
(() => x);
if (x == 1) {
if (x == "1") {
break;
}
if (x == 1) {
if (x == "1") {
break l00;
}
if (x == 2) {
if (x == "2") {
continue;
}
if (x == 2) {
if (x == "2") {
continue l00;
}
}
Expand Down Expand Up @@ -210,16 +210,16 @@ l00_c:
for (const x in []) {
(function() { return x});
(() => x);
if (x == 1) {
if (x == "1") {
break;
}
if (x == 1) {
if (x == "1") {
break l00_c;
}
if (x == 2) {
if (x == "2") {
continue;
}
if (x == 2) {
if (x == "2") {
continue l00_c;
}
}
Expand Down
2 changes: 1 addition & 1 deletion tests/cases/fourslash/forIn.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@

goTo.marker();

verify.quickInfoIs('var p: any', "");
verify.quickInfoIs('var p: string', "");